This repository has been archived by the owner on Nov 5, 2019. It is now read-only.
Getting client.py to 100% coverage. #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `DeviceFlowInfo` (and using datetime now patch). - Corner cases for `step1_get_authorize_url` and `step2_exchange` - Failure cases for `flow_from_clientsecrets` - `verify_id_token` when the cached HTTP is used (i.e. the default argument)
In particular: - `step1_get_device_and_user_codes` - `step2_exchange` with device info - Making explicit the `code=` argument in calls to `step2_exchange` in tests - `flow_from_clientsecrets` branches with revoke and device URI optional args
|
Woo hoo 100%! |
|
LGTM. |
|
Looks great; merge. |
|
Gonna merge this one, which will auto-merge #485. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
step1_get_device_and_user_codesstep2_exchangewith device infocode=argument in calls tostep2_exchangein testsflow_from_clientsecretsbranches with revoke anddevice URI optional args
NOTE: Has #485 as diffbase.